Fix incorrect image dimension handling in rotation logic#124
Open
sushantkhemalapure wants to merge 5 commits intohumanai-foundation:mainfrom
Open
Fix incorrect image dimension handling in rotation logic#124sushantkhemalapure wants to merge 5 commits intohumanai-foundation:mainfrom
sushantkhemalapure wants to merge 5 commits intohumanai-foundation:mainfrom
Conversation
- Updated TrOCR model path from ../../weights to ../../models - Ensures correct model loading instead of CRAFT weights
- Corrected unpacking of image.shape[:2] to (height, width) - Prevents distortion in rotated images
Author
|
Thanks for taking a look. Let me know if any changes are needed and I’ll update it quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The code incorrectly unpacks
image.shape[:2]as(width, height), while OpenCV returns(height, width).Fix
Updated the unpacking to correctly assign height and width.
Impact
Files Updated
Testing