Refactor utils: improve robustness, memory efficiency, and unify Gaussian noise functions#113
Open
agentksimha wants to merge 25 commits intohumanai-foundation:mainfrom
Open
Refactor utils: improve robustness, memory efficiency, and unify Gaussian noise functions#113agentksimha wants to merge 25 commits intohumanai-foundation:mainfrom
agentksimha wants to merge 25 commits intohumanai-foundation:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves utility functions by enhancing robustness, reducing redundancy, and improving performance. It adds path validation and better error handling to pdf_to_images, and makes count_lines_in_file memory-efficient using streaming while handling file existence, permission, encoding, and runtime errors. It also merges add_gaussian_noise and add_black_gaussian_noise into a single function with a mode parameter and updates all usages accordingly. Overall, this reduces code duplication, improves efficiency for large files, and makes the augmentation pipeline more flexible and maintainable.