pre-index match data to eliminate redundant loops in assembly#38
Open
agentksimha wants to merge 4 commits into
Open
pre-index match data to eliminate redundant loops in assembly#38agentksimha wants to merge 4 commits into
agentksimha wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find_best_assembly_match previously used 4 nested loops, reconstructing
a string pair_key and re-iterating all color buckets on every call
during the Step 4 assembly loop.
Changes:
flattens color buckets and indexes matches by fragment ID in both
directions for O(1) neighbour lookup
two inner loops with a single max() over a pre-flattened list
Time complexity of the assembly loop drops from O(N² · A · R · C · M)
to O(P·M) for the one-time index build + O(N · K · M) for all assembly
calls combined, where K is actual neighbours (sparse) vs R (full set)