Refactor ply_loader.py — robustness and observability improvements#37
Open
agentksimha wants to merge 3 commits into
Open
Refactor ply_loader.py — robustness and observability improvements#37agentksimha wants to merge 3 commits into
agentksimha wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three targeted improvements to PLYColorExtractor:
Point cloud fallback in load_ply: read_triangle_mesh silently returns an empty mesh for PLY files with no faces. Added fallback to read_point_cloud so these files are loaded correctly instead of being dropped without warning.
Load summary in process_all_fragments: After processing a directory, prints Loaded N/M fragments successfully so failed/skipped files are immediately visible in batch runs.
Configurable min_cluster_size: Moved from a hardcoded value on extract_break_surface_points to a class-level parameter (default: 50, no breaking change). Skip warnings now include the fragment filename and threshold value for easier debugging.