Fix/surface matcher remaining issues#32
Open
ishika24755 wants to merge 2 commits into
Open
Conversation
…nctions - compute_shape_similarity: return None instead of 0.95 when eigenvalues are missing, so the sub-score is excluded rather than fabricated. - compute_curvature_similarity: return None instead of clamping to 0.90 when both curvature histograms are all-zero (feature extraction failed). - compute_boundary_similarity: return None when neither boundary_length nor compactness is available; average only sub-metrics that have real values instead of using a 0.85 placeholder. - compute_overall_similarity: skip None sub-scores and renormalize the remaining weights to sum to 1.0, keeping the final score in [0, 1] and grounded entirely in available geometric data. Fixes: inflated match scores causing false-positive fragment pairings that corrupt downstream alignment and reconstruction quality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR about?
This cleans up three small but impactful bugs left over after the main fallback-score fixes in
fix/surface-matcher-fallback-scores. Each one could cause silent incorrect behavior or a runtime crash during matching.Changes
1. Curvature similarity — asymmetric zero check (
and→or)The previous check only returned
Nonewhen both histograms were zero. If just one fragment had missing curvature data, it would still compute a score against an empty histogram — producing a meaningless but non-zero result that feeds into the overall match score.