Refactor PLY loader with configurable colors and logging#25
Open
ironman1947 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hello maintainers
While exploring the preprocessing pipeline, I refactored ply_loader.py to improve code quality, maintainability, and robustness. The changes move away from hardcoded values and print debugging to a more production-ready approach.
Key Changes
DEFAULT_COLOR_CONFIGdictionary and added support for custom configurations in the loader initialization.printstatements with Python's standardloggingmodule (INFO,WARNING,ERROR,DEBUG) for better output control.List,Dict,Optional,o3d.geometry.TriangleMesh) to all methods.DBSCAN,matplotlib) and unused utility methods.Verification
reproduce_issue.pythat generates a dummy PLY file with known colored vertices.Notes
I’m continuing to explore the reconstruction pipeline and would really appreciate feedback on whether this direction aligns with the project goals. Happy to iterate if any changes are preferred.