Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper for torch dynamo #35478

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

oraluben
Copy link

@oraluben oraluben commented Jan 2, 2025

What does this PR do?

This PR adds two wrapper for torch dynamo to support different pytorch version. Models should benifit from these changes that they do not need to manually check pytorch version.

Update: This seems not urgent after #35358 (I also updated the requirements in #35479), but thers's still some API changing, e.g. torch._dynamo.external_utils.is_compiling -> torch.compiler.is_compiling, we might want to add them if some model use them.

@ArthurZucker @muellerzr

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@oraluben

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant