Fix new FA2 if is_causal is passed explicitly
#35390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
cc @ArthurZucker, this should be included in the coming release! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@Cyrilvallez not sure if |
|
We were using 'view' without 'contiguous' before the refactors, so this should be fine! |
|
Sounds good! Was just overly cautious then :) |
|
No worries, thanks for double-checking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In GPT2 we have to pass
is_causalexplicitly for SDPA, but it causes double occurence for FA2 as highlighted in #35380. This fixes it.Also reverts the
reshapeto simpleviewfor simplicity (even if they are technically equivalent, as reshape calls view if possible)