Fix to acquire the permit in a blocking way #726
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #662
Fixes #470 (?)
For a batch input, it spawns multiple asynchronous tasks, and each task calls an async-awaitable permit acquisition, whereas a single input does not.
Changes
try_acquire_permit()
instead ofacquire_permit()
for the batch case so that it immediately errors out instead of awaitingAlso, I came across while testing this, for many small requests, likewise [
a
,b
,c
,d
,e
], the Queue rarely fails to performappend()
ornext_batch()
due to a lack of capacity of the queue buffer. So, I temporarily doubled the buffer size to prevent this, which is obviously not a good way to handle this. (Maybe it'd be better to raise a 429 error when.try_send()
failed, too)We can reproduce it by following these steps.
Log
Before submitting
insta
snapshots?Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@Narsil @alvarobartt