Update the local attention mask
logic to work on MPS and CUDA in ModernBERT
#561
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In the previous PR #459,
local_attention
can only be worked onCPU
due to theabs()
operation.So, I've made a change to calculate the
window mask
in pure Rust and then create the Tensor from it. Maybe, this could makeModernBERT
run on both MPS and CUDA too.I've checked the output with this script and it seems identical to before.
tested devices
performance (
get_window_mask()
)Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@Narsil, @alvarobartt, @ivarflakstad