Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple tool example #293

Merged

Conversation

touseefahmed96
Copy link
Contributor

An Example for calling multiple tools in ToolCallingAgent

@aymeric-roucher
Copy link
Collaborator

Thank you @touseefahmed96, nice addition! Could you also add a commented out builder to make a CodeAgent instead, in order to emphasize that the two can be switched out easily?

@touseefahmed96
Copy link
Contributor Author

@aymeric-roucher I also added the CodeAgent and commented it. Also i have tested the code.

@aymeric-roucher
Copy link
Collaborator

Amazing @touseefahmed96 , LGTM 🚀

@aymeric-roucher
Copy link
Collaborator

@touseefahmed96 there's still a quality issue to change on the code! Also FYI later I'm going to remove the tool_calling in this example's name and set CodeAgent as the main example (we want to emphasize support of CodeAgent over ToolCallingAgent)

@touseefahmed96
Copy link
Contributor Author

@touseefahmed96 there's still a quality issue to change on the code! Also FYI later I'm going to remove the tool_calling in this example's name and set CodeAgent as the main example (we want to emphasize support of CodeAgent over ToolCallingAgent)

@aymeric-roucher What should i do to fix the quality issue on the code and do you want me to set the default agent to CodeAgent and comment the ToolCallingAgent?

@aymeric-roucher
Copy link
Collaborator

@touseefahmed96 for the quality of code, run ruff check examples --fix and ruff format examples
For your second question, yes please!

@touseefahmed96
Copy link
Contributor Author

@aymeric-roucher Fixed the quality issue and now default agent is CodeAgent

@albertvillanova
Copy link
Member

For future contributions, you can fix quality issues just running:

make style

@albertvillanova albertvillanova merged commit a806f50 into huggingface:main Jan 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants