Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass output_dir to superclass when initializing #585

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Pass output_dir to superclass when initializing #585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/setfit/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from sentence_transformers import SentenceTransformerTrainer, losses
from sentence_transformers.losses.BatchHardTripletLoss import BatchHardTripletLossDistanceFunction
from sentence_transformers.model_card import ModelCardCallback as STModelCardCallback
from sentence_transformers.training_args import BatchSamplers
from sentence_transformers.training_args import BatchSamplers, SentenceTransformerTrainingArguments
from sklearn.preprocessing import LabelEncoder
from torch import nn
from transformers import __version__ as transformers_version
Expand Down Expand Up @@ -47,7 +47,11 @@ def __init__(
self._setfit_model = setfit_model
self._setfit_args = setfit_args
self.logs_prefix = "embedding"
super().__init__(model=setfit_model.model_body, **kwargs)
super().__init__(
model=setfit_model.model_body,
args=SentenceTransformerTrainingArguments(output_dir=setfit_args.output_dir),
**kwargs,
)
self._apply_training_arguments(setfit_args)

for callback in list(self.callback_handler.callbacks):
Expand Down