-
Notifications
You must be signed in to change notification settings - Fork 818
Remove any hf-transfer related code #3444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Wauplin
wants to merge
12
commits into
v1.0-release
Choose a base branch
from
remove-hf-transfer
base: v1.0-release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+75
−370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
XciD
approved these changes
Oct 16, 2025
hanouticelina
approved these changes
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice cleaning! thank you
Co-authored-by: célina <[email protected]>
Co-authored-by: célina <[email protected]>
Co-authored-by: célina <[email protected]>
…ce_hub into remove-hf-transfer
bpronan
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that all repos are xet-enabled and that hf-xet is installed by default,
hf-transfer
is not used anymore. Let's remove it from codebase and docs in v1.0.TL;DR:
hf_transfer
extra from dependencieshf_transfer
related code => it'll be impossible to usehf_transfer
with huggingface_hub v1.0. This makes the code much cleaner in the upload/download workflowshf-xet
is the default (was already the case) but can still be disabled withHF_HUB_DISABLE_XET
which defaults to python-based file transferHF_HUB_ENABLE_HF_TRANSFER
is set but notHF_XET_HIGH_PERFORMANCE
, we warn the user for awarenessxetEnabled
logic from repo settings (as per https://github.com/huggingface-internal/moon-landing/pull/15243 -private link-) => all repos are xet-enabled cc @coyotte508hf_transfer
(or tell it's deprecated)TODO:
Note: this is a drawback for platforms for which hf-xet is not available (32 bits, mips, etc) but honestly I think it's more a feature than a bug. We should encourage users in this situation to report to us and we assess what we should do (I don't expect machines on 32bits to have very large bandwidth anyway^^).