Skip to content

feat: use ListLike instead of list in path type hints #8322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
N-S8990 wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −8
Open

feat: use ListLike instead of list in path type hints #8322

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bc1229
feat: use Sequence instead of list in path type hints
N-S8990 Jul 11, 2026
70d703a
feat: use ListLike instead of list in path type hints
N-S8990 Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/datasets/arrow_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1290,7 +1290,7 @@ def from_list(

@staticmethod
def from_csv(
path_or_paths: Union[PathLike, list[PathLike]],
path_or_paths: Union[PathLike, ListLike[PathLike]],
split: Optional[NamedSplit] = None,
features: Optional[Features] = None,
cache_dir: str = None,
Expand All @@ -1303,7 +1303,7 @@ def from_csv(
Read the CSV files, cache the data in Arrow format on disk and return the Dataset from the memory-mapped Arrow data on disk.

Args:
path_or_paths (`path-like` or list of `path-like`):
path_or_paths (`path-like` or `Sequence` of `path-like`):
Path(s) of the CSV file(s).
split ([`NamedSplit`], *optional*):
Split name to be assigned to the dataset.
Expand Down Expand Up @@ -1430,7 +1430,7 @@ def from_generator(

@staticmethod
def from_json(
path_or_paths: Union[PathLike, list[PathLike]],
path_or_paths: Union[PathLike, ListLike[PathLike]],
split: Optional[NamedSplit] = None,
features: Optional[Features] = None,
cache_dir: str = None,
Expand All @@ -1444,7 +1444,7 @@ def from_json(
Read the JSON files, cache the data in Arrow format on disk and return the Dataset from the memory-mapped Arrow data on disk.

Args:
path_or_paths (`path-like` or list of `path-like`):
path_or_paths (`path-like` or `Sequence` of `path-like`):
Path(s) of the JSON or JSON Lines file(s).
split ([`NamedSplit`], *optional*):
Split name to be assigned to the dataset.
Expand Down Expand Up @@ -1489,7 +1489,7 @@ def from_json(

@staticmethod
def from_parquet(
path_or_paths: Union[PathLike, list[PathLike]],
path_or_paths: Union[PathLike, ListLike[PathLike]],
split: Optional[NamedSplit] = None,
features: Optional[Features] = None,
cache_dir: str = None,
Expand All @@ -1506,7 +1506,7 @@ def from_parquet(
Read the Parquet files, cache the data in Arrow format on disk and return the Dataset from the memory-mapped Arrow data on disk.

Args:
path_or_paths (`path-like` or list of `path-like`):
path_or_paths (`path-like` or `Sequence` of `path-like`):
Path(s) of the Parquet file(s).
split (`NamedSplit`, *optional*):
Split name to be assigned to the dataset.
Expand Down Expand Up @@ -1586,7 +1586,7 @@ def from_parquet(

@staticmethod
def from_text(
path_or_paths: Union[PathLike, list[PathLike]],
path_or_paths: Union[PathLike, ListLike[PathLike]],
split: Optional[NamedSplit] = None,
features: Optional[Features] = None,
cache_dir: str = None,
Expand All @@ -1601,7 +1601,7 @@ def from_text(
Read the text files, cache the data in Arrow format on disk and return the Dataset from the memory-mapped Arrow data on disk.

Args:
path_or_paths (`path-like` or list of `path-like`):
path_or_paths (`path-like` or `Sequence` of `path-like`):
Path(s) of the text file(s).
split (`NamedSplit`, *optional*):
Split name to be assigned to the dataset.
Expand Down