feat(contentful): add paging in searchByKeywords #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asastre
requested review from
ericmarcos,
marcpdw,
vanbasten17,
elozano98 and
AinaVendrell
…piling with a direct require of perf_hooks dependency
vanbasten17
approved these changes
Jul 28, 2021
asastre
force-pushed
the
contentful/paging-keywords
branch
from
f4887ed to
5c60e05
Compare
This comment has been minimized.
This comment has been minimized.
Unit Test Results 1 files 7 suites 3m 10s ⏱️ Results for commit 5c60e05. ♻️ This comment has been updated with latest results. |
marcpdw
approved these changes
Jul 28, 2021
packages/botonic-plugin-contentful/tests/search/search-by-keywords.test.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pagingparameter insearchByKeywordsthe same way it's done withtopContents.perf_hooksdependency that was making the bot's webpack to fail when compiling.Context
Contentful requests have a limit of 100 contents and some times there's a need to obtain more than 100 contents when searching by keywords.
Approach taken / Explain the design
If no paging object is passed to
searchByKeywordsthe default one (with a limit of 1000) wil be set.To document / Usage example
Testing
The pull request has no tests.