Fixes infinite create board loop #358
Conversation
… board create offer also
| <div class="create-new-board--message"> | ||
| <ul class="create-new-board--list"> | ||
| <li>You will need write permission on <%= @parameters['user'] %>/<%= @parameters['repo'] %></li> | ||
| <li>If <%= @parameters['user'] %> is a GitHub Organization: <a href=https://help.github.com/articles/disabling-third-party-application-restrictions-for-your-organization/" target="blank">ensure no access restrictions are present</a></li> |
There was a problem hiding this comment.
href has end quote but no start quote.
discorick
changed the title
…ate-loop+refactor Refactors to BEM and cleans up some markup
|
Some of the styling is broken for the view after the BEM refactor, going to take another stab at with your improvements in place @rauhryan ! |
|
Do you have a screenshot? |
|
This one:
|
|
What's wrong with it? |
|
It supposed to be a list of items, the original look is up in my original screenshots ☝️ |
|
Okie dokie, I changed it cause I thought it looked weird. Sent from my iPhone
|
|
Lulz, I thought the red line looked weird. If you are cool with how it is now I am happy to let a design discussion slide around these views to when we overhaul them. |
|
I'll leave it to you Sent from my iPhone
|
Fixes the infinite loop and closes #357
Additionally, as the changes required some styling, applied a bit of a facelift to the board create process altogether:
When prompted to create a board (buttons light up on hover):
When third party access restrictions are present:
When push bit is missing:
@rauhryan @dahlbyk What do you think? Improvement ?