[Experimental] Replaces Intercom with Gitter Sidecar in the app #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
discorick
changed the title
discorick
force-pushed
the
discorick/replace-intercom-with-gitter
branch
from
2141e8c to
15c3241
Compare
discorick
force-pushed
the
discorick/replace-intercom-with-gitter
branch
from
15c3241 to
c5ddec5
Compare
dahlbyk
reviewed
Jan 23, 2017
| @@ -14,13 +14,12 @@ | |||
| </head> | |||
| <body class="flex-body" id="application"> | |||
|
|
|||
| <%= render partial: "shared/analytics" %> | |||
There was a problem hiding this comment.
I don't think we want to remove this, just disable Intercom in Segment.
There was a problem hiding this comment.
Can do that as well, though for the ember app I believe the only thing we use it for is the intercom chat widget.
There was a problem hiding this comment.
98% sure we also feed GA via Segment for tracking the board page view.
There was a problem hiding this comment.
Oh right for the board page you on GA you are correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playing with using Gitter (wired to
huboard/huboard) rather than intercom to help facilitate more thought sharing and discussion in the app.