Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NickAkhmetov/v0.2.7 Hotfix upstream build issues, remove redundant logs #93

Merged
merged 4 commits into from
Oct 17, 2024
Merged

NickAkhmetov/v0.2.7 Hotfix upstream build issues, remove redundant logs #93

merged 4 commits into from
Oct 17, 2024

Conversation

NickAkhmetov
Copy link
Collaborator

This PR:

  • Bumps the minor version to 0.2.7
  • Pins vitessce to 3.4.0 to work around spatialdata breaking search-api deploy
  • Removes some redundant spammy logs left over from troubleshooting

@NickAkhmetov NickAkhmetov requested review from lchoy and tkakar October 17, 2024 15:43
@NickAkhmetov NickAkhmetov changed the title NickAkhmetov/v0.2.7 Hotfix NickAkhmetov/v0.2.7 Hotfix upstream build issues, remove redundant logs Oct 17, 2024
tkakar
tkakar approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@tkakar tkakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. could you please point me to the source of mapping between version and the change-log (if exists), I could not find it.

@NickAkhmetov
Copy link
Collaborator Author

The changelog for portal-visualization is generated when we tag and create a release in GitHub, e.g.: https://github.com/hubmapconsortium/portal-visualization/releases

@NickAkhmetov NickAkhmetov merged commit 60fc83e into main Oct 17, 2024
2 checks passed
@NickAkhmetov NickAkhmetov deleted the nickakhmetov/0.2.7-build-fix branch October 17, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkakar tkakar tkakar approved these changes

@lchoy lchoy Awaiting requested review from lchoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NickAkhmetov @tkakar