NickAkhmetov/CAT-1111, CAT-965, CAT-1148 Organ Page Fixes #3692
+34
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prove organ lookup logic to accept search terms as synonyms
austenem
reviewed
Feb 12, 2025
context/app/utils.py
Outdated
| if len(search) > 0: | ||
| for s in search: | ||
| organ_file_names[s.lower()] = k | ||
| print(organ_file_names) |
There was a problem hiding this comment.
Does this print statement need to be here?
There was a problem hiding this comment.
It does not, left over from troubleshooting :) Thanks for catching it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a few issues all related to the organ page:
urinary bladderpage now includesbladderdatasetsovaryandfallopian tubepages now include appropriate search terms for handling laterality, i.e. they now include the left/right ovary and fallopian tube datasets, respectively.Design Documentation/Original Tickets
Fallopian tube/ovary/bladder datasets missing from organ page: https://hms-dbmi.atlassian.net/browse/CAT-1111
Missing organ icon: https://hms-dbmi.atlassian.net/browse/CAT-965
Cellpop plot controls overlap with appbar: https://hms-dbmi.atlassian.net/browse/CAT-1148
Testing
Manually tested and confirmed existing unit tests remained intact.
Screenshots/Video
Updated organ pages screenshots (click to expand)
Urinary Bladder:
Fallopian Tube:
Ovary:
Bladder icon is now present:
Cellpop no longer overlaps with appbar:
Screen.Recording.2025-02-12.101444.mp4
Checklist
CHANGELOG-your-feature-name-here.mdis present in the root directory, describing the change(s) in full sentences.Additional Notes
Please specify any additional information or context relevant to this PR.