Austenem/CAT-1113 Add list metrics #3689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickAkhmetov
requested changes
Feb 11, 2025
Comment on lines
355
to
376
| function useHandleSaveEntity({ entityUUID }: { entityUUID: string }) { | ||
| const { | ||
| entity: { entity_type }, | ||
| } = useFlaskDataContext(); | ||
| const [entityData] = useEntitiesData([entityUUID], ['hubmap_id']); | ||
|
|
||
| return useCallback(() => { | ||
| handleSaveEntities({ entityUUIDs: new Set([entityUUID]) }).catch((error) => { | ||
| console.error(error); | ||
| }); | ||
|
|
||
| if (!entityData?.length) { | ||
| return; | ||
| } | ||
|
|
||
| trackEvent({ | ||
| category: SavedListsEventCategories.EntityDetailPage(entity_type), | ||
| action: 'Save Entity to Items', | ||
| label: entityData[0].hubmap_id, | ||
| }); | ||
| }, [entityUUID, entityData, entity_type]); | ||
| } |
There was a problem hiding this comment.
Could this be defined outside of the useListSavedListsAndEntities hook, i.e. as its own hook? Since running this function instantiates new hook calls, calling this function at runtime could cause errors related to varying numbers of hooks per render.
austenem
added a commit
that referenced
this pull request
Feb 13, 2025
* add ukv endpoint * pull authenticated lists into my lists page * implement add functionality * refactor hooks * update deletion functionality * update lists functionality * fix typing * add entity to list functionality * edit and deletion functionality * liststobedeleted functionality * remove savedlistscontent * update stores * move logic to hooks * typescript conversions and list page update * adjust useeffect and language * add documentation, minor updates * fix re-rendering issue * copy over local lists and entities * update local to remote copy logic * update save entity logic * update alerts * continue adding alerts * add save entities button to search page * update saved items table, add button to table * adjust button tooltips * add barrel files * convert to ts * continue conversions * separate out api and store * update tests * fix minor uuid bug, adjust menu button * sort items * continue to add sorting * clean up and add changelog * update list page * update isLoading bool to pass test * remove lists page for unauthenticated users * refactor alerts * hide list buttons from unauthenticated users * finish refactoring hooks * fix new list dialog * minor updates and extend alerts * update jest test * update test and implement copy logic * update hook to use default export * update storage description * minor cleanup * finish deleting stores * update logged out description * add save entity button to processed datasets * review cleanup 1 * update import * update hooks * Austenem/CAT-1135 Update /services (#3687) * add ukv service * remove logs * add changelog * memoize entity counts * Austenem/CAT-1113 Add list metrics (#3689) * add categories and update organ page table * finish adding tracking * finish adding tested tracking * consolidate save entity tracking * update imports * add changelog * add ref * add additional check * separate out save entity hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds metrics for the "My Lists" feature.
Design Documentation/Original Tickets
CAT-1113 Jira ticket
Testing
Tested using Matomo and event logging.
Checklist
CHANGELOG-your-feature-name-here.mdis present in the root directory, describing the change(s) in full sentences.