Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NickAkhmetov/scFind #3667

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

NickAkhmetov
Copy link
Collaborator

@NickAkhmetov NickAkhmetov commented Jan 15, 2025

Summary

This PR is a work in progress. It is a feature branch for the integration of scFind into the portal.

This PR currently includes:

  • the setup for the hooks to access various scFind endpoints.
  • tests for formatting of endpoint URLs/params

Design Documentation/Original Tickets

Link to any design documents, diagrams, or JIRA tickets relevant to this feature.

Testing

scFind hooks

  • Unit tests for URL param construction
  • Storybook page with interface for interacting with hooks/scFind API

Screenshots/Video

Not yet available.

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

Additional Notes

The js/api directory is a new addition working towards CAT-919, which involves reorganizing data fetching hooks into a consistent format.

The approach I've taken should minimize coupling between data fetching hooks and should encourage us to use them to compose other hooks, rather than integrating data fetching and processing into a single hook. In the long term, if we are able to switch the project from Webpack/CJS to Vite/ESM, this approach will enable more fine-grained code splitting.

@NickAkhmetov NickAkhmetov force-pushed the nickakhmetov/scfind-preliminary branch from de588cb to 0943a71 Compare February 12, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant