Update Node version in Github Action workflow scripts #3351
Conversation
|
The actions should already be using the node version specified in the .nvmrc file; was there an issue of some sort? |
|
The version in the .nvmrc is not supported. See https://github.com/actions/setup-node#supported-version-syntax. As a result, the workflow produces this warning about overriding the default to 16: I opened the PR (set to draft) to force the workflow to run. Goal is to use a consistent version of the action and node-version. Perhaps Also, am planning to remove the |
The version in the .nvmrc is Regardless of whether the action uses the .nvmrc file or not (I still strongly prefer using the |
Co-authored-by: John Conroy <[email protected]>
* Add hooks to update workspaces * Add store to control edit dialog * Create basic workspace name dialog * Reset form on open * Handle disabled button tooltip * Pass mouse events to tooltip button * Fix update types * Handle update errors * Dedupe workspace stores * Share workspace form fields * Jump through typescript hoops * Add step styling to modal * Pull template select step into own component * Pull out create templates hook for reuse * Add edit templates dialog * Match templates in current workspace details * Add comment * Disable templates already in workspace * Do not select disabled templates when selecting all * Add tooltip if template is already in workspace * Create reusable edit workspace dialog * Move workspace templates and datasets into swr hook * Handle reset after submit successful * Consolidate edit dialogs * Add changelog * Pass workspace datasets to new templates * Fix TS errors related to template form types (#3353) * Update context/app/static/js/shared-styles/cards/SelectableCard/SelectableCard.tsx Co-authored-by: Nikolay Akhmetov <[email protected]> * Use store instead of props * Use padding prop in stack in step * Use promise chain to avoid async submit callback * Console error error --------- Co-authored-by: John Conroy <[email protected]> Co-authored-by: Nikolay Akhmetov <[email protected]>
* Add tutorials routes to flask * Add tutorial route to js * Add tutorials page * Add workspace tutorial * Use mui styles * Add tutorial to workspaces page * Add changelog --------- Co-authored-by: John Conroy <[email protected]>
* NickAkhmetov/Fix organ counts * remove unnecessary separate return
* Add fusion link and fix azimuth casing * Add changelog * Add tracking * Fix callback --------- Co-authored-by: John Conroy <[email protected]>
* Add utm source param to fusion link * Add changelog --------- Co-authored-by: John Conroy <[email protected]>
Modifies the version string in .nvmrc to remove the 'v' prefix to enable compatibility with GitHub Action workflow scripts. Update action workflow scripts to use the node-version-file.