John conroy/update workspace templates #3350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-conroy
changed the base branch from
john-conroy/update-workspace-name
to
main
NickAkhmetov
reviewed
Dec 1, 2023
Comment on lines
41
to
44
| } finally { | ||
| reset(); | ||
| close(); | ||
| } |
There was a problem hiding this comment.
Does this finally clause execute even if handleSubmit fails? Should we catch errors here as well, even if we don't do anything with them?
There was a problem hiding this comment.
Moved the error handling outside of the fetch hook and into the submit callback using a similar recipe to the one used in the Copy button from an earlier PR.
context/app/static/js/components/workspaces/EditWorkspaceDialog/EditWorkspaceDialog.tsx
Outdated
Show resolved
Hide resolved
context/app/static/js/components/workspaces/EditWorkspaceDialog/EditWorkspaceDialog.tsx
Outdated
Show resolved
Hide resolved
context/app/static/js/shared-styles/cards/SelectableCard/SelectableCard.tsx
Outdated
Show resolved
Hide resolved
…tableCard.tsx Co-authored-by: Nikolay Akhmetov <[email protected]>
lchoy
pushed a commit
that referenced
this pull request
Dec 13, 2023
* Add hooks to update workspaces * Add store to control edit dialog * Create basic workspace name dialog * Reset form on open * Handle disabled button tooltip * Pass mouse events to tooltip button * Fix update types * Handle update errors * Dedupe workspace stores * Share workspace form fields * Jump through typescript hoops * Add step styling to modal * Pull template select step into own component * Pull out create templates hook for reuse * Add edit templates dialog * Match templates in current workspace details * Add comment * Disable templates already in workspace * Do not select disabled templates when selecting all * Add tooltip if template is already in workspace * Create reusable edit workspace dialog * Move workspace templates and datasets into swr hook * Handle reset after submit successful * Consolidate edit dialogs * Add changelog * Pass workspace datasets to new templates * Fix TS errors related to template form types (#3353) * Update context/app/static/js/shared-styles/cards/SelectableCard/SelectableCard.tsx Co-authored-by: Nikolay Akhmetov <[email protected]> * Use store instead of props * Use padding prop in stack in step * Use promise chain to avoid async submit callback * Console error error --------- Co-authored-by: John Conroy <[email protected]> Co-authored-by: Nikolay Akhmetov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards HPM-465.
A few known issues:
mutaterequest returns to refresh the workspace data. We will likely have to handle this using SWR with an optimistic UI approach.