Mccalluc/workspace list #2715
Merged
Mccalluc/workspace list #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 28, 2022
john-conroy
reviewed
Jun 29, 2022
| <pre>{JSON.stringify(workspace, 0, 2)}</pre> | ||
| </details> | ||
| <div> | ||
| <b>{workspace.name}</b> | Created {workspace.datetime_created.slice(0, 10)} |
There was a problem hiding this comment.
Not sure what the format is here, but we should move this towards being consistent with how other dates are formatted throughout the portal.
Comment on lines
+30
to
+42
| async function startJob({ workspaceId, workspacesEndpoint, workspacesToken }) { | ||
| await fetch(`${workspacesEndpoint}/workspaces/${workspaceId}/start`, { | ||
| method: 'PUT', | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| 'UWS-Authorization': `Token ${workspacesToken}`, | ||
| }, | ||
| body: JSON.stringify({ | ||
| job_type: 'JupyterLabJob', | ||
| job_details: {}, | ||
| }), | ||
| }); | ||
| } |
There was a problem hiding this comment.
Based on our conversation in standup, we want to make another GET to jobs and update jobs state here, right?
There was a problem hiding this comment.
Ok, I see the changes in #2717. Thanks!
There was a problem hiding this comment.
Yep... but I hit some snags there, so filed #2717 and will come back to it.
Co-authored-by: John Conroy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull lists of workspaces and jobs from the API. Ugly, but it has surfaced a number of problems with the API. Juan has been making hot fixes for some, and filed issues for others:
This does not include the changes you suggested to that creation API calls will also update the lists. I'll push a separate branch for that... I was getting into the weeds.