Skip to content

#1967 Adding rename method#1968

Closed
sbouchexbellomie-Philips wants to merge 9 commits intohub4j:mainfrom
sbouchexbellomie-Philips:branch-rename
Closed

#1967 Adding rename method#1968
sbouchexbellomie-Philips wants to merge 9 commits intohub4j:mainfrom
sbouchexbellomie-Philips:branch-rename

Conversation

@sbouchexbellomie-Philips
Copy link
Copy Markdown

Description

This fix is adding branch renaming support (fix #1967)

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

Comment thread src/main/java/org/kohsuke/github/GHBranch.java Outdated
Copy link
Copy Markdown
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. One suggestion.
Then record the data for the new test by following the instructions in CONTRIBUTING.md.

Thanks!

@bitwiseman bitwiseman added the work-abandoned There hasn't been any activity on the PR in a while. Another contributor might want to pick it up. label Jan 14, 2025
@bitwiseman bitwiseman marked this pull request as draft January 14, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

work-abandoned There hasn't been any activity on the PR in a while. Another contributor might want to pick it up.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Branch rename is missing

2 participants