Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Refactor auth handling to address issue #1594 #1610

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Refactor auth handling to address issue #1594 #1610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions httpie/plugins/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ def load_installed_plugins(self, directory: Optional[Path] = None):

# Auth
def get_auth_plugins(self) -> List[Type[AuthPlugin]]:
return self.filter(AuthPlugin)
return [plugin for plugin in self if issubclass(plugin, AuthPlugin)]
# return self.filter(AuthPlugin)

def get_auth_plugin_mapping(self) -> Dict[str, Type[AuthPlugin]]:
return {
Expand All @@ -107,7 +108,8 @@ def get_converters(self) -> List[Type[ConverterPlugin]]:

# Adapters
def get_transport_plugins(self) -> List[Type[TransportPlugin]]:
return self.filter(TransportPlugin)
return [plugin for plugin in self if issubclass(plugin, TransportPlugin)]
# return self.filter(TransportPlugin)

def __str__(self):
return repr_dict({
Expand Down
Loading