Add ArmeriaServerBuilder#withMaxRequestLength
#570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danicheg
commented
Dec 3, 2024
| @@ -50,7 +50,9 @@ class ArmeriaServerBuilderSuite extends CatsEffectSuite with ServerFixture { | |||
| IO(Thread.currentThread.getName).flatMap(Ok(_)) | |||
|
|
|||
| case req @ POST -> Root / "echo" => | |||
| Ok(req.body) | |||
There was a problem hiding this comment.
An interesting issue occurred with the previous version of request body handling: the test suite hanged when running a test to check for exceeding the maxRequestLength limit. This was likely caused by an exception com.linecorp.armeria.common.ContentTooLargeException propagated from Armeria to fs2 Stream. Ultimately, the request's body stream wasn't consumed resulting in not releasing some resources and hanging. It raises an interesting question about how we handle that exception from Armeria in the integration, but I'll leave it for another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing
ServerBuilder#maxRequestLengthinArmeriaServerBuilderfor handiness.