Use join instead of run, to avoid infinite rendering errors #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When many instances of the async-image component are present simultaneously (our example is an infinite scrolling page of photos), we encountered an "infinite rendering invalidation detected" error. It appears to be a similar issue to the one described here: ember-redux/ember-redux#69, wherein the use of
run
creates a new run loop for each async-image instance.In order to avoid this issue, and as a general performance improvement, I've switched to using
join
, so that each async-image's_onload
or_onError
will queue itself on an existing run loop, if available.