Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use join instead of run, to avoid infinite rendering errors #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edkeeble
Copy link

When many instances of the async-image component are present simultaneously (our example is an infinite scrolling page of photos), we encountered an "infinite rendering invalidation detected" error. It appears to be a similar issue to the one described here: ember-redux/ember-redux#69, wherein the use of run creates a new run loop for each async-image instance.

In order to avoid this issue, and as a general performance improvement, I've switched to using join, so that each async-image's _onload or _onError will queue itself on an existing run loop, if available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant