Skip to content

Fix bug #1378 and create a regression test. #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025
Merged

Fix bug #1378 and create a regression test. #1379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29cbf7f
Fix bug #1378 and create a regression test.
threeifbyair Mar 26, 2025
f574719
Renamed new test file to *-error.cpp2
hsutter Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions regression-tests/pure2-bugfix-for-bad-using-error.cpp2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
main: () = {
using
}
3 changes: 3 additions & 0 deletions regression-tests/test-results/pure2-bugfix-for-bad-using-error.cpp2.output
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
pure2-bugfix-for-bad-using-error.cpp2...
pure2-bugfix-for-bad-using-error.cpp2(3,1): error: expected valid id-expression after 'using' (at '}')

3 changes: 1 addition & 2 deletions source/parse.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2275,8 +2275,7 @@ struct using_statement_node
auto for_namespace() const
-> bool
{
assert(id);
return id->to_string().ends_with("::_");
return (id && id->to_string().ends_with("::_"));
}

auto position() const
Expand Down
Loading