Change Snap confinement to "classic", add hooks that add/remove session #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@apachelogger, will you merge this PR? |
|
The snap (currently) is intentionally not classic. The idea is to have it eventually fully confined even so as to not be able to break anything. The better way IMO is to fix snapd to allow creating xsession files in some form or fashion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"A hook is an executable that runs within a snap’s confined environment when a certain action occurs" ‒ Snapcraft Docs
I added scripts that create symlink to session file (plasma.desktop) in /usr/share/xsessions/ when installing or updating, and remove symlink when uninstalling.
I change confinement to "classic" for access to root for create symlink.
In GNOME Software users see this inscription:
Thanks to AlanGriffiths/egmde-snap