Fix transform #818
Draft
Fix transform #818
+41
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #818 +/- ##
==========================================
+ Coverage 83.38% 83.55% +0.17%
==========================================
Files 39 47 +8
Lines 3918 5601 +1683
==========================================
+ Hits 3267 4680 +1413
- Misses 651 921 +270 🚀 New features to boost your workflow:
|
cameronangliss
force-pushed
the
fix-transform
branch
from
d72a720 to
4c60c42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires smogon/pokemon-showdown#11676
The non-strict integration tests were occasionally getting jammed up in the nightly's, and I found out it is due to transform being poorly tracked. This can be fixed by making sure the species field isn't changed when a pokemon transforms, which currently messes up the
BattleOrdermessage sent to Showdown.