Added items and ability as gen data + updated data #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #769 +/- ##
==========================================
+ Coverage 83.38% 84.98% +1.59%
==========================================
Files 39 46 +7
Lines 3918 5307 +1389
==========================================
+ Hits 3267 4510 +1243
- Misses 651 797 +146 🚀 New features to boost your workflow:
|
hsahovic
requested changes
Sep 5, 2025
Owner
hsahovic
left a comment
hsahovic
left a comment
There was a problem hiding this comment.
Thanks for opening this PR - this is a good idea.
I think there's something weird about the data cleaning, as it looks like some of the moves were updated with data from later gen (eg. crabhammer with 100 bp in the gen 1 file). Can you fix it?
| "crabhammer": { | ||
| "accuracy": 85, | ||
| "basePower": 90, | ||
| "basePower": 100, |
Owner
There was a problem hiding this comment.
How did that happen? I think this is incorrect - crabhammer had a base power of 90 in gen1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to have at least the list of items and abilities for vectorization of observable data for machine learning.
I added scripts/update_items.py and scripts/update_abilities.py with the same format as the other update script.
I think the helper function data_script_utils.py > fetch_and_clean_ps_data() was not working properly on these data but also in moves.py, with the help of LLM I could tweak the regex a bit to have it work on everything currently online.
I also ran update_all_data.py to update all the data
FYI I'm not yet 100% familiar with everything in the poke-env and showdown ecosystem. In the item data many items have the inherit attribute, Idk if it's related their effect or if it's just a coding artifact that we should get rid of since it doesn't concern the ed user.