-
-
Notifications
You must be signed in to change notification settings - Fork 135
Cleaner env forfeiting #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…errors ("game is not over")
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #750 +/- ##
==========================================
+ Coverage 83.38% 84.95% +1.57%
==========================================
Files 39 46 +7
Lines 3918 5304 +1386
==========================================
+ Hits 3267 4506 +1239
- Misses 651 798 +147 🚀 New features to boost your workflow:
|
1d6fad8 to
79a397d
Compare
83a9b2a to
932f22f
Compare
hsahovic
approved these changes
Sep 5, 2025
caymansimpson
pushed a commit
to caymansimpson/poke-env
that referenced
this pull request
Sep 6, 2025
* improvements to help example not throw benign but concerning-looking errors ("game is not over")
* unused import
* fix mypy
* much better way of doing this with new _EmptyBattleOrder
* format
* simplify
* slight adjustment
* unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up some benign but concerning-looking
CRITICALlogs when running examples/reinforcement_learning.py. Note that when we run the example file, we still get a stream ofWARNINGlogs because the example does not include action masking to ensure that the chosen action is valid. This is expected and good behavior as we have setstrict=Falsein the example, and the warning no longer shows up once you have #762, as an action mask is automatically generated by the environment and used in the example code, thereby avoiding the need to setstrict=False.Instead of one player sending /forfeit and the other sending /default, which sometimes results in the default-sending player getting a showdown warning that the game is already over and it can't make a decision, we now just send /forfeit from one player and nothing from the other. Also, a benign username overlap was resolved in the example code by setting
start_listening=Falseon the opponent Player object.