Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online: Fix DNS server default, show revival team credits on pause screen #19875

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

hrydgard
Copy link
Owner

@anr2me noted that we had the wrong default DNS in #19850 , so fixing that.

@hrydgard hrydgard added Networking / adhoc User Interface PPSSPP's own user interface / UX labels Jan 15, 2025
@hrydgard hrydgard added this to the v1.19.0 milestone Jan 15, 2025
@anr2me
Copy link
Collaborator

anr2me commented Jan 15, 2025

We should also removes the "en_US": "Works, but not on Windows", on MoHH game, since it works on Windows now.

We should also use timeout on built-in DNS resolver to prevent it from freezing forever, just need to use setsockopt on the socket.

struct timeval tv;
tv.tv_sec = 5;
tv.tv_usec = 0;
if (setsockopt(sockfd, SOL_SOCKET, SO_RCVTIMEO,&tv,sizeof(tv)) < 0) {
    // print error
}

@hrydgard
Copy link
Owner Author

hrydgard commented Jan 15, 2025

True, fixing. I'll add a timeout in the next change, as that will require a bit more logic.

@hrydgard hrydgard enabled auto-merge January 15, 2025 08:46
@hrydgard hrydgard disabled auto-merge January 15, 2025 08:46
@hrydgard hrydgard merged commit 008aaa8 into master Jan 15, 2025
16 checks passed
@hrydgard hrydgard deleted the online-ui-work branch January 15, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Networking / adhoc User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants