-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AtracDecodeDataRemainFrameHack #18396
base: master
Are you sure you want to change the base?
Conversation
Return less than 1 RemainFrame in AtracDecodeDataRemain to get valid data,then psp will call sceAtracAddStreamData and sceAtracGetStreamDataInfo.
I wondered whether this can also fix all of those audio issue on other games too or not, most of them seems to use atrac3+ too. |
I just find a game (K-ON_Houkago_Live_JPN) that jpcsp emulator decode Atrac audio also have problem (infinite loading after save ) |
in ppsspp side, I think that in looping with (atrac->bufferState_ == ATRAC_STATUS_STREAMED_LOOP_FROM_END) need to do something in some where because sceAtracAddStreamData give corrupt atrac data after loop 2 times |
I find a reasonable fix K-ON_Houkago_Live_JPN but unlucky not match JPCSPTrace log. |
I find better hack which can apply more game (which replace AtracLoopHack ) } else if (bytes_read < 0) { |
keep return less than 1 RemainFrame in sceAtracDecodeData to get valid data .when RemainFrame = 0 ,then psp will call sceAtracAddStreamData and sceAtracGetStreamDataInfo.
Work around #15233
Modify log:
https://gist.githubusercontent.com/sum2012/2209e25bdc9cfe79f5a57337fbf67f11/raw/484d6e234e829bc393aefc8614996eba1d09497f/gistfile1.txt