add slowly, insistently and related rate-setting functions #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bob,
Just wondered if you would like to have this PR with slowly/insistently adverbs. I have stripped away all tidyverse-dependent code and simplified verbosity a bit.
Let me know if this is something of interest. I intend to be using these in {polite} and thought it could be nice to have them as part of freebase.
Rate functions can be probably further simplified or re-written to get rid of S3 classes. Let me know what is your view on complexity/maintainability requirement for these functions. Eventually users would have to maintain them, so I guess they should be as simple as possible. On the other hand, your error handling code in
safely()is pretty terse.