Skip to content

refactor: Broadcast element-wise multiply - #120

Open
Tom-Finke wants to merge 5 commits into
mainfrom
refactor_broadcast-element-wise-multiply
Open

Tom-Finke wants to merge 5 commits into
mainfrom
refactor_broadcast-element-wise-multiply

Conversation

@Tom-Finke

Copy link
Copy Markdown
Collaborator

Use the Vectorized dot operator (.*) for element wise SecureArray multiplication instead of plain multiply (*) operator.

This is in preparation for introducing Matrix Multiplication (#50), which will use * for consistency with the julia stdlib.

@codecov

codecov Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
examples/simple_array_operations.jl 100.00% <100.00%> (ø)
examples/simple_matrix_operations.jl 100.00% <100.00%> (ø)
examples/simple_real_numbers.jl 100.00% <100.00%> (ø)
src/arithmetic.jl 100.00% <100.00%> (ø)
src/openfhe.jl 95.60% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Tom-Finke
Tom-Finke marked this pull request as ready for review September 25, 2026 09:28
@Tom-Finke

Copy link
Copy Markdown
Collaborator Author

@sloede please review

@Tom-Finke

Copy link
Copy Markdown
Collaborator Author

This PR introduces breaking changes, as the old sv * sv will no longer perform element wise multiplication . Should we update the version number to 0.3?

@Tom-Finke
Tom-Finke requested a review from sloede September 25, 2026 09:29

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant