set acls on new VOs if filesystem supports them #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpoely86
reviewed
Sep 11, 2025
lib/vsc/administration/vo.py
Outdated
| vo_modgrp_name = f"{self.vo.vsc_id}_mod" | ||
| vo_modgrp_gid = grp.getgrnam(vo_modgrp_name).gr_gid | ||
| except KeyError: | ||
| logging.exception("VO moderator group does not exist: %s", vo_modgrp_name) |
There was a problem hiding this comment.
does it need to exist? Cause that means the LDAP sync needs to run before this runs in case of a new VO
There was a problem hiding this comment.
The VO mod group needs to exist on the client system running this script, not on the NFS server.
We can ignore the existence of the group mapping on the NFS server by directly passing the GID. But we need to know the GID of the group, so it needs to at least exist on the system running this script.
wpoely86
reviewed
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In VUB we are going to start controlling access to our VOs with ACLs. To this end we need that
vsc-administrationattaches the configured ACLs on creation of new VOs.This is controlled through the configuration in
/etc/filesystem_info.conf(VscStorage). If the VO is created in a filesystem that hasacl_permissions_vodefined, it will attach those ACLs to the root folder of the VO.Companion PRs: