Disable verify-test-owners.sh and make go vet more obvious

hpcloud · Dec 21, 2016 · 05c09b1 · 05c09b1
1 parent 1955ed6
commit 05c09b1
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 1 deletion.
diff --git a/hack/make-rules/verify.sh b/hack/make-rules/verify.sh
@@ -26,6 +26,7 @@ EXCLUDED_CHECKS=(
   "verify-linkcheck.sh"  # runs in separate Jenkins job once per day due to high network usage
   "verify-govet.sh"      # it has a separate make vet target
   "verify-staging-client-go.sh" # TODO: enable the script after 1.5 code freeze
+  "verify-test-owners.sh"  # TODO(rmmh): figure out how to avoid endless conflicts
   )
 
 function is-excluded {

diff --git a/hack/make-rules/vet.sh b/hack/make-rules/vet.sh
@@ -46,4 +46,5 @@ if [[ ${#targets[@]} -eq 0 ]]; then
   targets=$(go list -e ./... | egrep -v "/(third_party|vendor|staging|clientset_generated)/")
 fi
 
+set -x
 go vet "${goflags[@]:+${goflags[@]}}" ${targets[@]}
diff --git a/hack/verify-test-owners.sh b/hack/verify-test-owners.sh
@@ -24,6 +24,5 @@ source "${KUBE_ROOT}/hack/lib/init.sh"
 cd "${KUBE_ROOT}"
 if ! hack/update_owners.py --check; then
     echo 'Run ./hack/update_owners.py to fix it'
-    exit  # TODO(rmmh): fix Github merging to respect .gitattributes
     exit 1
 fi
-Original file line number
+Diff line change
@@ Expand Up / @@ -46,4 +46,5 @@ if [[ ${#targets[@]} -eq 0 ]]; then @@
       targets=$(go list -e ./... | egrep -v "/(third_party|vendor|staging|clientset_generated)/")
     fi
+    set -x
     go vet "${goflags[@]:+${goflags[@]}}" ${targets[@]}