Sat sim tweaks2 (#725)

* Increase sat sim verbosity

* Add reporting

* Fix typo

* Indicate the correct reference frame

* Fix coordinate system conversion during pointing expansion

* Add coordinate system support to satellite simulation

* Improve reporting

* Clean up code

* Refactor map writing into a separate method

* Fix unit test failure

* Refactor mapmaker for better readability

* Run source formatter

* Refactor template solver

* Add --sample_rate and --fsample to toast_sim_satellite.py

* Add gpu staging to coordinate rotated boresight (#750)

* Eventually, this could be moved to a dedicated operator which
  creates rotated boresight pointing.

* For now, this is handled by the pointing_detector operator,
  and the rotated boresight is created if needed, and moved to
  the appropriate device.

* Restore original defaults

---------

Co-authored-by: Theodore Kisner <[email protected]>

src/toast/instrument.py

@@ -1,4 +1,4 @@
-# Copyright (c) 2019-2023 by the parties listed in the AUTHORS file.
+# Copyright (c) 2019-2024 by the parties listed in the AUTHORS file.
 # All rights reserved.  Use of this source code is governed by
 # a BSD-style license that can be found in the LICENSE file.
 
@@ -267,6 +267,7 @@ def _position_velocity(self, times):
         vel_z = np.zeros(n_sparse, np.float64)
         for i, t in enumerate(sparse_times):
             atime = astime.Time(t, format="unix")
+            # Get the satellite position and velocity in the equatorial frame (ICRS)
             p, v = coord.get_body_barycentric_posvel("earth", atime)
             # FIXME:  apply translation from earth center to L2.
             pm = p.xyz.to_value(u.kilometer)