Skip to content

21118: Adds warnings to train and set_feature_attributes about violated feature bounds #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

21118: Adds warnings to train and set_feature_attributes about violated feature bounds #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
58d4fc2
impl and test
cademack Aug 7, 2024
ce027a4
rename method, prevent repeat warnings
cademack Aug 7, 2024
94b1e9b
no query alternate version
cademack Aug 7, 2024
5df8e50
optimizations
cademack Aug 7, 2024
a0131ba
let
cademack Aug 7, 2024
dd5aa92
more holistic moving of code
cademack Aug 7, 2024
d47e2a5
dont prime bad caches
cademack Aug 7, 2024
eb321e1
remove old comment
cademack Aug 8, 2024
b12555f
remove set-feature-attributes check and fix mnist test
cademack Aug 8, 2024
5e35612
Merge branch 'main' into 21118-out-of-bounds-warnings
howsohazard Aug 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion howso/attributes.amlg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,8 @@
continuous_to_nominal_dependents_map (null)
nominal_to_nominal_dependents_map (null)
novel_substition_feature_set (null)

warnings (assoc)
))

(call !UpdateAttributesForDateTimeDataTypes)
Expand Down Expand Up @@ -536,7 +538,10 @@

(accum_to_entities trainee (assoc !revision 1))

(call !Return (assoc payload !featureAttributes))
(call !Return (assoc
warnings (if (size warnings) (indices warnings))
payload !featureAttributes
))
)

#!ComposeCustomDerivedMethods
Expand Down
1 change: 0 additions & 1 deletion howso/hyperparameters.amlg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,7 +694,6 @@
; analyze_threshold: optional, stores the threshold for the number of cases at which the model should be re-analyzed. default of 100.
; analyze_growth_factor: the factor by which to increase the analyze threshold everytime the model grows to the current threshold size
; default of two orders of magnitude using the universal scaling factor e
; auto_analyze_limit_size: optional, the size of of the model at which to stop doing outo-analysis
#set_params
(declare
(assoc
Expand Down
Loading