0000: Added typing and linting tooling framework, setup shared vscode workspace configuration #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 16, 2025 13:16
lancegliser
commented
Apr 16, 2025
| def format_string_column( | ||
| cls, | ||
| column: pd.Series, | ||
| feature: Mapping # noqa: ARG003 |
There was a problem hiding this comment.
Example fix for keeping an used arg. It'd just be ARG001, ARG002, etc for the #.
lancegliser
commented
Apr 16, 2025
| required: false | ||
| type: string | ||
| debug-mode: | ||
| description: Enables GDB and Amalgam Fast Memory Integrity checks for all Linux/x86 Pytest jobs. |
There was a problem hiding this comment.
Looks like my prettier plugin caught a ton of lines here. The only real changes here are adding:
enable-ruff: true
# enable-pyright: true
lancegliser
commented
Apr 17, 2025
| return False, 'Cannot write to this path' | ||
|
|
||
| except Exception as e: # noqa: Deliberately broad | ||
| except Exception as e: # Deliberately broad |
There was a problem hiding this comment.
There's many of these warnings in the output in pipeline. The comment is meaningful, but it's not the same as a QA check disable. We probably want to correct the entire list at some point.
warning: Invalid `# noqa` directive on howso/client/client.py:220: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/client/client.py:354: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/features.py:314: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/features.py:392: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/features.py:432: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/features.py:504: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/features.py:557: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/features.py:608: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/scikit/scikit.py:216: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/scikit/scikit.py:233: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/scikit/scikit.py:317: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/scikit/scikit.py:1266: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/feature_attributes/relational.py:498: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/feature_attributes/relational.py:881: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/client/base.py:4264: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/client/base.py:4266: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/utilities.py:604: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/utilities.py:724: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/utilities.py:1057: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/feature_attributes/pandas.py:231: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/feature_attributes/pandas.py:336: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/feature_attributes/pandas.py:363: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/feature_attributes/pandas.py:450: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/internals.py:561: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/internals.py:862: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/tests/__init__.py:39: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/installation_verification.py:45: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/installation_verification.py:49: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/installation_verification.py:56: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/installation_verification.py:266: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/installation_verification.py:691: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/installation_verification.py:724: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/installation_verification.py:767: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/installation_verification.py:777: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/installation_verification.py:820: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/installation_verification.py:831: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/installation_verification.py:890: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/installation_verification.py:948: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/installation_verification.py:1012: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/installation_verification.py:1022: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on howso/utilities/installation_verification.py:1142: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
There was a problem hiding this comment.
This causes a problem with Martin's tooling setup. Will need to review the issue for ways to coexist.
lancegliser
changed the title
lancegliser
commented
Apr 17, 2025
lancegliser
commented
Apr 24, 2025
| # IDE files | ||
| .vscode | ||
| # VSCode | ||
| .vscode/* |
There was a problem hiding this comment.
This will cause local .vscode entries to have to be removed before pulling main if merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.