Remove requestSubmit polyfill
#908
Conversation
|
I believe it is too early to remove it. Many people are still on devices that can't upgrade to Safari 16+. See https://caniuse.com/mdn-api_htmlformelement_requestsubmit with "Usage relative" selected. As a side note, is there a browser support policy for the project? |
|
Would it be an appropriate stance to consider inlined, built-in polyfills outside the bounds of |
|
I'm not a maintainer and I realise there is a burden keeping polyfills within the Turbo codebase. That being said, as a user and someone setting up Turbo for several companies, I appreciate the library working out of the box with browsers that still have enough users. |
seanpdoyle
force-pushed
the
remove-request-submit-polyfill
branch
from
7ade411 to
b157ce0
Compare
|
As a data point, we still support Safari 14.1+ at Basecamp. Safari is particularly sticky because versions are tied to the OS and the OS is tied to the hardware so when we deprecate one Safari version we may be forcing customers to updated their hardware. |
A polyfill for [HTMLFormElement.requestSubmit][] was introduced and inlined as part of the [7.1.0][] release. As of April 2023, that method has total support and 100% [Compatibility][] with evergreen browsers. This commit removes that polyfill. [HTMLFormElement.requestSubmit]: https://developer.mozilla.org/en-US/docs/Web/API/HTMLFormElement/requestSubmit [7.1.0]: hotwired@d4805a4 [Compatibility]: https://developer.mozilla.org/en-US/docs/Web/API/HTMLFormElement/requestSubmit#browser_compatibility
seanpdoyle
force-pushed
the
remove-request-submit-polyfill
branch
from
b157ce0 to
ae13da5
Compare
|
@jorgemanrubia @brunoprietog is the removal of this polyfill worth re-considering? |
A polyfill for HTMLFormElement.requestSubmit was introduced and inlined as part of the 7.1.0 release.
As of April 2023, that method has total support and 100% Compatibility with evergreen browsers.
This commit removes that polyfill.