Fix navigating to the turbo-root does not use Turbo Drive #1341
+64
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzmg
approved these changes
Nov 21, 2024
brunoprietog
requested changes
Jan 8, 2025
There was a problem hiding this comment.
Hi @leofeyer, thanks. I did a quick first pass and left minor styling suggestions.
| @@ -25,7 +25,7 @@ export function getExtension(url) { | |||
| } | |||
|
|
|||
| export function isPrefixedBy(baseURL, url) { | |||
| const prefix = getPrefix(url) | |||
| const prefix = getPrefix(url) || '/' | |||
There was a problem hiding this comment.
Suggested change
| const prefix = getPrefix(url) || '/' | |
| const prefix = getPrefix(url) || "/" |
| import { assert } from "chai" | ||
| import { nextBody, pathname, visitAction } from "../helpers/page" | ||
|
|
||
| test("test visiting a location inside the root", async ({ page }) => { |
There was a problem hiding this comment.
Suggested change
| test("test visiting a location inside the root", async ({ page }) => { | |
| test("visiting a location inside the root", async ({ page }) => { |
| assert.notEqual(await visitAction(page), "load") | ||
| }) | ||
|
|
||
| test("test visiting the root itself", async ({ page }) => { |
There was a problem hiding this comment.
Suggested change
| test("test visiting the root itself", async ({ page }) => { | |
| test("visiting the root itself", async ({ page }) => { |
| assert.notEqual(await visitAction(page), "load") | ||
| }) | ||
|
|
||
| test("test visiting a location outside the root", async ({ page }) => { |
There was a problem hiding this comment.
Suggested change
| test("test visiting a location outside the root", async ({ page }) => { | |
| test("visiting a location outside the root", async ({ page }) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #912
This is just a copy of #913 with the merge conflicts resolved, so credits should go to @tobyzerner.