Fix devcontainer configuration #1256
Conversation
|
@robzolkos is there anything else needed to merge this? |
Jut the attention of a maintainer. This cleans things up a fair bit. |
radanskoric
force-pushed
the
fix-devcontainer
branch
from
b88538c to
1aa04b6
Compare
|
@brunoprietog I've updated the PR. I also had to slightly bump @playwright/test to 1.30.0 because we already had playwright-core at both 1.28.0 and 1.30.0 through different dependency chains, causing issues. Unit test were trying to run with 1.28 and browser tests with 1.30 which is a problem when the docker image has just one playwright build. Playwright should probably also be bumped to latest, 1.45.3. I'm happy to do that as well but I concluded it's best left for next PR, to limit the scope of this one. |
radanskoric
force-pushed
the
fix-devcontainer
branch
from
1aa04b6 to
c1be304
Compare
|
Happy to see a PR updating Playwright! Maybe it will be helpful in reducing some flaky tests |
The devcontainer was no longer working since chrome version 115 because location of installation files changed. See comment on: https://chromedriver.chromium.org/downloads However we don't need to build it ourselves since Microsoft maintains docker images with playwright preinstalled with chrome, firefox and webkit. This means that we can simplify the setup a lot while still keeping the goal of allowing people to get an environment in which they can run tests by simply starting a devcontainer or running a Github codespace. I also had to slightly bump @playwright/test to 1.30.0 because we already had both 1.28.0 and 1.30.0 through different dependency chains, causing issues. Unit test were trying to run with 1.28 and browser tests with 1.30 which is a problem when our docker image has just one playwright build.
radanskoric
force-pushed
the
fix-devcontainer
branch
from
989f9d7 to
ca4effe
Compare
I wanted to try some changes to turbo source on to get myself started quickly I tried using the devcontainer setup but it didn't work. So instead I spent the time debugging that issue.
The devcontainer was no longer working since chrome version 115 because location of installation files changed. See comment on: https://chromedriver.chromium.org/downloads
However we don't need to build it ourselves since Microsoft maintains docker images with playwright preinstalled with chrome, firefox and webkit.
This means that we can simplify the setup a lot while still keeping the goal of allowing people to get an environment in which they can run tests by simply starting a devcontainer or running a Github codespace.
I've just tested this now by launching a github codespace from this here branch on my fork. After waiting a bit, I was able to just write
yarn testand it worked. (Strangely there were a few tests that failed.They were flaky, the runner re-ran them and they passed and where flagged as flaky by the runner)