-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reload or recreate web view when its process is terminated #187
Conversation
…of the web content process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AMAZING! So excited for this one.
First two comments are more suggestions, feel free to ignore them if you don't agree.
But I think we need to address the last one at the end of the PR. Unless I'm missing something.
Lastly, if I have two tabs open they both seem to reload at the same time when triggering a killed web view.
… to the library.
Co-authored-by: Joe Masilotti <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I made one small request of moving where the internal function lives. But feel fine merging either way.
This PR improves handling of the terminated web view processes which leave the web views with a white screen.
@zoejessica did a thorough investigation on this topic. The following is taken from one of our PRs at 37signals.
This PR takes care of all three cases.
TurboNavigator
needs to track the app's state (active or background) in order to decide when to reload the terminated web views. To facilitate this, I've added two public functions:appDidBecomeActive()
andappDidEnterBackground()
.