Bump packages - #27
Conversation
|
Warning Review limit reached
Next review available in: 51 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThe module configuration now targets Go 1.25.0 and updates six indirect ChangesGo toolchain updates
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 3: Update the documentation or supported-platform matrix to state macOS
12 as the minimum supported version, replacing any macOS 11 references. Do not
modify CI workflows, which already derive the Go version from go.mod.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8a917a83-4a93-4037-a42d-a7119c57b6db
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
| module github.com/hostinger/terraform-provider-hostinger | ||
|
|
||
| go 1.24.2 | ||
| go 1.25.0 |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
go version
go env GOTOOLCHAIN
rg -n --hidden -g '!.git' \
-e '1\.24(\.[0-9]+)?' \
-e 'setup-go|go-version|golang:' \
-e 'darwin|macos|GOOS|GOARCH' .Repository: hostinger/terraform-provider-hostinger
Length of output: 873
🏁 Script executed:
cat -n go.mod | head -50Repository: hostinger/terraform-provider-hostinger
Length of output: 2674
🌐 Web query:
Go 1.25 macOS minimum version requirement
💡 Result:
Go 1.25 requires macOS 12 (Monterey) or later [1][2]. Support for macOS 11 and earlier versions was discontinued beginning with the Go 1.25 release [1][3]. Users requiring support for macOS 11 must continue using the Go 1.24 release series [4][3].
Citations:
- 1: https://go.dev/doc/go1.25
- 2: https://go.dev/wiki/MinimumRequirements
- 3: all: end support for macOS 11 in Go 1.25 golang/go#69839
- 4: https://trac.macports.org/ticket/72828
🏁 Script executed:
python3 - <<'PY'
# Check the golang.org/x modules mentioned in lines 37-42
modules = [
("golang.org/x/mod", "v0.35.0"),
("golang.org/x/net", "v0.55.0"),
("golang.org/x/sync", "v0.20.0"),
("golang.org/x/sys", "v0.45.0"),
("golang.org/x/text", "v0.37.0"),
("golang.org/x/tools", "v0.44.0"),
]
print("golang.org/x module versions in go.mod:")
for mod, version in modules:
print(f" {mod} {version}")
PYRepository: hostinger/terraform-provider-hostinger
Length of output: 382
🌐 Web query:
golang.org/x/mod v0.35.0 golang.org/x/net v0.55.0 minimum Go version requirements compatibility
💡 Result:
For the specified versions of the Go supplementary modules, the minimum Go version requirements are as follows: - golang.org/x/mod v0.35.0 requires Go 1.25.0 [1]. - golang.org/x/net v0.55.0 requires Go 1.25.0 [2]. In the Go module system, the go directive in the go.mod file declares the minimum version of the Go toolchain required to compile the module [3][4]. If your project depends on these modules, your own module's go.mod file must specify a Go version that is greater than or equal to the requirement of your dependencies [3][4]. If your environment uses a Go version older than what is specified in a dependency's go.mod file, the Go toolchain will refuse to use that module [3][4]. You can verify the minimum Go version requirement for any specific package version by checking its documentation on pkg.go.dev [1][2] or by inspecting the go directive directly in the repository's go.mod file [5].
Citations:
- 1: https://pkg.go.dev/golang.org/x/mod@v0.35.0
- 2: https://pkg.go.dev/golang.org/x/net@v0.55.0
- 3: https://go.dev/doc/modules/gomod-ref
- 4: https://go.dev/ref/mod
- 5: https://github.com/golang/net/blob/master/go.mod
🏁 Script executed:
fd -type f \( -name "Dockerfile*" -o -name "*.dockerfile" -o -name ".python-version" -o -name ".nvmrc" \) -o -path "*docker*" -type fRepository: hostinger/terraform-provider-hostinger
Length of output: 347
🏁 Script executed:
rg -n "golang:|FROM.*go|go.*1\.[0-9]+\.[0-9]+" --type dockerfile --type yaml --type json .Repository: hostinger/terraform-provider-hostinger
Length of output: 211
🏁 Script executed:
find . -type f \( -name "Dockerfile*" -o -name "*.yml" -o -name "*.yaml" \) | head -20Repository: hostinger/terraform-provider-hostinger
Length of output: 277
🏁 Script executed:
rg -n "golang:|FROM.*go|go.*1\.[0-9]+" --type yaml .Repository: hostinger/terraform-provider-hostinger
Length of output: 176
🏁 Script executed:
cat -n .goreleaser.ymlRepository: hostinger/terraform-provider-hostinger
Length of output: 2411
🏁 Script executed:
cat -n .github/workflows/release.ymlRepository: hostinger/terraform-provider-hostinger
Length of output: 1877
🏁 Script executed:
cat -n .github/workflows/lint.ymlRepository: hostinger/terraform-provider-hostinger
Length of output: 830
🏁 Script executed:
fd -type f -name "README*" | head -5Repository: hostinger/terraform-provider-hostinger
Length of output: 347
🏁 Script executed:
rg -i "macos|darwin|minimum|supported|version" README* -A 2 -B 2 2>/dev/null | head -50Repository: hostinger/terraform-provider-hostinger
Length of output: 266
Verify Go version requirements are documented as macOS 12 minimum.
This upgrade is necessary—the updated golang.org/x/* dependencies (mod v0.35.0, net v0.55.0, etc.) require Go 1.25.0 (pkg.go.dev). Go 1.25 requires macOS 12 or later; if your documentation or supported platform matrix lists macOS 11, update it. CI workflows are already configured to follow go.mod automatically via go-version-file, so no CI changes are needed.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 3, Update the documentation or supported-platform matrix to
state macOS 12 as the minimum supported version, replacing any macOS 11
references. Do not modify CI workflows, which already derive the Go version from
go.mod.
2 participants
This pull request focuses on improving resource management and updating dependencies in the project. The main changes include switching all
defer resp.Body.Close()calls to a safer closure pattern throughout the codebase, updating Go and dependency versions, and modernizing the lint workflow.Resource management improvements:
defer resp.Body.Close()withdefer func() { _ = resp.Body.Close() }()in HTTP response handling across multiple files (e.g.,hostinger/client.go,hostinger/dns_record.go,hostinger/vps_data_sources.go,hostinger/vps_data_sources_validation.go,hostinger/vps_post_install_script.go,hostinger/vps_ssh_key_resource.go). This ensures any error fromClose()is explicitly ignored, preventing possible linter warnings and improving code robustness. [1] [2] [3] [4] [5] [6] and related references)Dependency and tooling updates:
go.modto 1.25.0.golang.org/x/mod,golang.org/x/net, etc.) to newer versions ingo.mod.go.modand upgradedgolangci-lint-actionfrom v6 to v8 for improved CI reliability and compatibility.These changes enhance code quality, maintainability, and ensure the project uses up-to-date tooling and dependencies.