chore: qualify X-Pack task modules with FQCNs

[hex-botas]

📝 Summary by DEX CODE

• Chores
  • Qualified the remaining bare module invocations in the X-Pack and security task files with their fully qualified ansible.builtin.* names, bringing them in line with the rest of the role and with ansible-lint's fqcn[action-core] rule.
  • No behaviour change: only module keys were renamed, leaving arguments, conditions and privilege settings untouched.

What

Qualify the 8 remaining bare module invocations in the X-Pack task files with their ansible.builtin.* FQCNs.

File	Modules qualified
tasks/xpack/elasticsearch-xpack.yml	file
tasks/xpack/security/elasticsearch-security.yml	command ×4, shell ×2, template

Why

The FQCN migration is already partly done in this role — tasks/main.yml, tasks/elasticsearch-RedHat.yml, tasks/elasticsearch-parameters.yml and tasks/elasticsearch-plugins.yml use ansible.builtin.* throughout, and tasks/xpack/elasticsearch-xpack.yml already qualifies its include_tasks while leaving the file task bare in the same file. Mixed styles inside one file are the inconsistency this closes.

FQCNs are also what ansible-lint wants (fqcn[action-core]), and ansible-lint>=6.0 is pinned in requirements.txt, so this moves the role toward re-enabling the currently commented-out lint job in .github/workflows/molecule.yml.

Scope

Deliberately limited to the X-Pack task files (8 instances). Other task files still carry bare module names — tasks/elasticsearch-ssl.yml, tasks/elasticsearch-Debian.yml, tasks/xpack/security/elasticsearch-security-file.yml and elasticsearch-security-native.yml are the largest remaining ones, and are left for follow-up PRs rather than bundled here.

Risk

Low. Key renames only — no behaviour, argument, ordering, when, become, environment or no_log changes. ansible.builtin.* is the canonical name for each of these modules, so resolution is identical.

Testing

No unit tests changed: tests/ covers filter_plugins/custom.py only and no Python was touched, so unit-test coverage is unaffected. The default, security and custom-config Molecule scenarios exercise these tasks — the security scenario covers the keystore and role_mapping.yml tasks directly — and run on this PR via CI.

---

Generated by DEX CODE
Triggered by agent:weekly-code-improvements

[hex-botas]

🔍 DEX CODE review

✅ Looks good — no issues found.

All 8 changes are module-key renames to the canonical ansible.builtin.* names (file, command ×4, shell ×2, template); arguments, args/environment/when/become/no_log siblings and task ordering are untouched, and the result matches the FQCN style already used in tasks/main.yml and the include_tasks in the same X-Pack file. Title follows the Conventional Commits rule in AGENTS.md.

PR authored by hex-botas[bot]; reviewing own work — approval is not recorded on Hex-authored PRs.

Last reviewed: 2026-09-15 05:05 UTC

---

Generated by DEX CODE
Triggered by hex-botas[bot]