[UTILS] Move ReflectionUtils to bookkeeper-common module

Descriptions of the changes in this PR:

*Motivation*

RefelectionUtils contains helpers for loading classes from relections.
It is useful across the project. However the class is in `bookkeeper-server` module only.

*Changes*

Move this class to `bookkeeper-common` module




Reviewers: Jia Zhai <None>

This closes apache#1841 from sijie/move_reflection_utils

bookkeeper-server/src/main/java/org/apache/bookkeeper/util/ReflectionUtils.java → bookkeeper-common/src/main/java/org/apache/bookkeeper/common/util/ReflectionUtils.java

@@ -1,5 +1,4 @@
 /*
- *
  * Licensed to the Apache Software Foundation (ASF) under one
  * or more contributor license agreements.  See the NOTICE file
  * distributed with this work for additional information
@@ -16,9 +15,8 @@
  * KIND, either express or implied.  See the License for the
  * specific language governing permissions and limitations
  * under the License.
- *
  */
-package org.apache.bookkeeper.util;
+package org.apache.bookkeeper.common.util;
 
 import java.lang.reflect.Constructor;
 import java.util.Map;

bookkeeper-server/src/test/java/org/apache/bookkeeper/util/TestReflectionUtils.java → bookkeeper-common/src/test/java/org/apache/bookkeeper/common/util/TestReflectionUtils.java

@@ -17,9 +17,9 @@
  * under the License.
  */
 
-package org.apache.bookkeeper.util;
+package org.apache.bookkeeper.common.util;
 
-import static org.apache.bookkeeper.util.ReflectionUtils.forName;
+import static org.apache.bookkeeper.common.util.ReflectionUtils.forName;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;

bookkeeper-server/src/main/java/org/apache/bookkeeper/auth/AuthProviderFactoryFactory.java

@@ -22,12 +22,11 @@
 
 import java.io.IOException;
 import org.apache.bookkeeper.client.BKException;
+import org.apache.bookkeeper.common.util.ReflectionUtils;
 import org.apache.bookkeeper.conf.ClientConfiguration;
 import org.apache.bookkeeper.conf.ServerConfiguration;
 import org.apache.bookkeeper.proto.BookieConnectionPeer;
 import org.apache.bookkeeper.proto.ClientConnectionPeer;
-import org.apache.bookkeeper.util.ReflectionUtils;
-
 
 /**
  * A factory to manage the authentication provider factories.

bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerStorageFactory.java

@@ -22,7 +22,7 @@
 
 import java.io.IOException;
 
-import org.apache.bookkeeper.util.ReflectionUtils;
+import org.apache.bookkeeper.common.util.ReflectionUtils;
 
 /**
  * A factory that creates {@link LedgerStorage} by reflection.

bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java

@@ -58,6 +58,7 @@
 import org.apache.bookkeeper.client.api.WriteFlag;
 import org.apache.bookkeeper.common.util.OrderedExecutor;
 import org.apache.bookkeeper.common.util.OrderedScheduler;
+import org.apache.bookkeeper.common.util.ReflectionUtils;
 import org.apache.bookkeeper.conf.AbstractConfiguration;
 import org.apache.bookkeeper.conf.ClientConfiguration;
 import org.apache.bookkeeper.feature.FeatureProvider;
@@ -77,7 +78,6 @@
 import org.apache.bookkeeper.proto.DataFormats;
 import org.apache.bookkeeper.stats.NullStatsLogger;
 import org.apache.bookkeeper.stats.StatsLogger;
-import org.apache.bookkeeper.util.ReflectionUtils;
 import org.apache.bookkeeper.util.SafeRunnable;
 import org.apache.commons.configuration.ConfigurationException;
 import org.apache.commons.lang.SystemUtils;

bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java

@@ -48,6 +48,7 @@
 import org.apache.bookkeeper.client.BKException.BKNotEnoughBookiesException;
 import org.apache.bookkeeper.client.BookieInfoReader.BookieInfo;
 import org.apache.bookkeeper.client.WeightedRandomSelection.WeightedObject;
+import org.apache.bookkeeper.common.util.ReflectionUtils;
 import org.apache.bookkeeper.conf.ClientConfiguration;
 import org.apache.bookkeeper.conf.Configurable;
 import org.apache.bookkeeper.feature.FeatureProvider;
@@ -62,7 +63,6 @@
 import org.apache.bookkeeper.net.StabilizeNetworkTopology;
 import org.apache.bookkeeper.stats.OpStatsLogger;
 import org.apache.bookkeeper.stats.StatsLogger;
-import org.apache.bookkeeper.util.ReflectionUtils;
 import org.apache.commons.collections4.CollectionUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;

bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java

@@ -30,14 +30,14 @@
 import lombok.extern.slf4j.Slf4j;
 import org.apache.bookkeeper.common.util.JsonUtil;
 import org.apache.bookkeeper.common.util.JsonUtil.ParseJsonException;
+import org.apache.bookkeeper.common.util.ReflectionUtils;
 import org.apache.bookkeeper.feature.Feature;
 import org.apache.bookkeeper.meta.AbstractZkLedgerManagerFactory;
 import org.apache.bookkeeper.meta.HierarchicalLedgerManagerFactory;
 import org.apache.bookkeeper.meta.LedgerManagerFactory;
 import org.apache.bookkeeper.meta.LongHierarchicalLedgerManagerFactory;
 import org.apache.bookkeeper.util.EntryFormatter;
 import org.apache.bookkeeper.util.LedgerIdFormatter;
-import org.apache.bookkeeper.util.ReflectionUtils;
 import org.apache.bookkeeper.util.StringEntryFormatter;
 import org.apache.commons.configuration.CompositeConfiguration;
 import org.apache.commons.configuration.ConfigurationException;

bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java

@@ -26,10 +26,10 @@
 import org.apache.bookkeeper.client.EnsemblePlacementPolicy;
 import org.apache.bookkeeper.client.LedgerHandle;
 import org.apache.bookkeeper.client.RackawareEnsemblePlacementPolicy;
+import org.apache.bookkeeper.common.util.ReflectionUtils;
 import org.apache.bookkeeper.discover.RegistrationClient;
 import org.apache.bookkeeper.discover.ZKRegistrationClient;
 import org.apache.bookkeeper.replication.Auditor;
-import org.apache.bookkeeper.util.ReflectionUtils;
 import org.apache.commons.configuration.ConfigurationException;
 
 

bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java

@@ -24,12 +24,12 @@
 import org.apache.bookkeeper.bookie.InterleavedLedgerStorage;
 import org.apache.bookkeeper.bookie.LedgerStorage;
 import org.apache.bookkeeper.bookie.SortedLedgerStorage;
+import org.apache.bookkeeper.common.util.ReflectionUtils;
 import org.apache.bookkeeper.discover.RegistrationManager;
 import org.apache.bookkeeper.discover.ZKRegistrationManager;
 import org.apache.bookkeeper.stats.NullStatsProvider;
 import org.apache.bookkeeper.stats.StatsProvider;
 import org.apache.bookkeeper.util.BookKeeperConstants;
-import org.apache.bookkeeper.util.ReflectionUtils;
 import org.apache.commons.configuration.ConfigurationException;
 
 /**

bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManagerFactory.java

@@ -22,10 +22,10 @@
 import java.util.List;
 import java.util.Objects;
 import lombok.extern.slf4j.Slf4j;
+import org.apache.bookkeeper.common.util.ReflectionUtils;
 import org.apache.bookkeeper.conf.AbstractConfiguration;
 import org.apache.bookkeeper.meta.LayoutManager.LedgerLayoutExistsException;
 import org.apache.bookkeeper.meta.zk.ZKMetadataDriverBase;
-import org.apache.bookkeeper.util.ReflectionUtils;
 import org.apache.commons.configuration.ConfigurationException;
 import org.apache.zookeeper.KeeperException;
 import org.apache.zookeeper.ZKUtil;

bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MetadataDrivers.java

@@ -37,13 +37,13 @@
 import lombok.NoArgsConstructor;
 import lombok.ToString;
 import lombok.extern.slf4j.Slf4j;
+import org.apache.bookkeeper.common.util.ReflectionUtils;
 import org.apache.bookkeeper.conf.ClientConfiguration;
 import org.apache.bookkeeper.conf.ServerConfiguration;
 import org.apache.bookkeeper.discover.RegistrationManager;
 import org.apache.bookkeeper.meta.exceptions.Code;
 import org.apache.bookkeeper.meta.exceptions.MetadataException;
 import org.apache.bookkeeper.stats.NullStatsLogger;
-import org.apache.bookkeeper.util.ReflectionUtils;
 import org.apache.commons.configuration.ConfigurationException;
 import org.apache.commons.lang3.StringUtils;
 

bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/MetastoreFactory.java

@@ -17,7 +17,7 @@
  */
 package org.apache.bookkeeper.metastore;
 
-import org.apache.bookkeeper.util.ReflectionUtils;
+import org.apache.bookkeeper.common.util.ReflectionUtils;
 
 /**
  *  Metastore Factory.

bookkeeper-server/src/main/java/org/apache/bookkeeper/server/component/ServerLifecycleComponent.java

@@ -26,9 +26,9 @@
 import org.apache.bookkeeper.common.annotation.InterfaceStability.Evolving;
 import org.apache.bookkeeper.common.component.AbstractLifecycleComponent;
 import org.apache.bookkeeper.common.component.LifecycleComponent;
+import org.apache.bookkeeper.common.util.ReflectionUtils;
 import org.apache.bookkeeper.server.conf.BookieConfiguration;
 import org.apache.bookkeeper.stats.StatsLogger;
-import org.apache.bookkeeper.util.ReflectionUtils;
 
 /**
  * A {@link LifecycleComponent} that runs on a bookie server. It can be loaded via reflections.

bookkeeper-server/src/main/java/org/apache/bookkeeper/server/service/StatsProviderService.java

@@ -19,11 +19,11 @@
 package org.apache.bookkeeper.server.service;
 
 import java.io.IOException;
+import org.apache.bookkeeper.common.util.ReflectionUtils;
 import org.apache.bookkeeper.server.component.ServerLifecycleComponent;
 import org.apache.bookkeeper.server.conf.BookieConfiguration;
 import org.apache.bookkeeper.stats.NullStatsLogger;
 import org.apache.bookkeeper.stats.StatsProvider;
-import org.apache.bookkeeper.util.ReflectionUtils;
 
 /**
  * A {@link org.apache.bookkeeper.common.component.LifecycleComponent} that runs stats provider.

bookkeeper-server/src/main/java/org/apache/bookkeeper/tls/SecurityProviderFactoryFactory.java

@@ -17,7 +17,7 @@
  */
 package org.apache.bookkeeper.tls;
 
-import org.apache.bookkeeper.util.ReflectionUtils;
+import org.apache.bookkeeper.common.util.ReflectionUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 

bookkeeper-server/src/main/java/org/apache/bookkeeper/util/EntryFormatter.java

@@ -21,6 +21,7 @@
 
 package org.apache.bookkeeper.util;
 
+import org.apache.bookkeeper.common.util.ReflectionUtils;
 import org.apache.bookkeeper.conf.AbstractConfiguration;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;

bookkeeper-server/src/main/java/org/apache/bookkeeper/util/LedgerIdFormatter.java

@@ -23,6 +23,7 @@
 
 import java.util.UUID;
 
+import org.apache.bookkeeper.common.util.ReflectionUtils;
 import org.apache.bookkeeper.conf.AbstractConfiguration;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;

stream/distributedlog/core/src/main/java/org/apache/distributedlog/DistributedLogConfiguration.java

@@ -25,11 +25,11 @@
 import java.util.ArrayList;
 import java.util.Iterator;
 import java.util.Set;
+import org.apache.bookkeeper.common.util.ReflectionUtils;
 import org.apache.bookkeeper.conf.ClientConfiguration;
 import org.apache.bookkeeper.feature.FeatureProvider;
 import org.apache.bookkeeper.net.DNSToSwitchMapping;
 import org.apache.bookkeeper.stats.StatsLogger;
-import org.apache.bookkeeper.util.ReflectionUtils;
 import org.apache.commons.configuration.CompositeConfiguration;
 import org.apache.commons.configuration.Configuration;
 import org.apache.commons.configuration.ConfigurationException;

stream/distributedlog/core/src/main/java/org/apache/distributedlog/namespace/NamespaceDriverManager.java

@@ -26,7 +26,7 @@
 import java.util.Set;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.ConcurrentMap;
-import org.apache.bookkeeper.util.ReflectionUtils;
+import org.apache.bookkeeper.common.util.ReflectionUtils;
 import org.apache.commons.lang.StringUtils;
 import org.apache.distributedlog.DistributedLogConstants;
 import org.apache.distributedlog.impl.BKNamespaceDriver;

stream/distributedlog/core/src/main/java/org/apache/distributedlog/tools/Tool.java

@@ -19,7 +19,7 @@
 
 import java.util.Map;
 import java.util.TreeMap;
-import org.apache.bookkeeper.util.ReflectionUtils;
+import org.apache.bookkeeper.common.util.ReflectionUtils;
 import org.apache.commons.cli.BasicParser;
 import org.apache.commons.cli.CommandLine;
 import org.apache.commons.cli.HelpFormatter;

stream/distributedlog/core/src/test/java/org/apache/distributedlog/tools/TestDistributedLogTool.java

@@ -23,7 +23,7 @@
 
 import java.net.URI;
 import org.apache.bookkeeper.client.BKException.BKNoSuchLedgerExistsException;
-import org.apache.bookkeeper.util.ReflectionUtils;
+import org.apache.bookkeeper.common.util.ReflectionUtils;
 import org.apache.distributedlog.DLMTestUtil;
 import org.apache.distributedlog.DLSN;
 import org.apache.distributedlog.DistributedLogConfiguration;

tests/shaded/distributedlog-core-shaded-test/src/test/java/org/apache/bookkeeper/tests/shaded/DistributedLogCoreShadedJarTest.java

@@ -30,14 +30,14 @@
 import static org.mockito.Mockito.when;
 
 
+import dlshade.org.apache.bookkeeper.common.util.ReflectionUtils;
 import dlshade.org.apache.bookkeeper.conf.AbstractConfiguration;
 import dlshade.org.apache.bookkeeper.conf.ServerConfiguration;
 import dlshade.org.apache.bookkeeper.meta.AbstractZkLedgerManagerFactory;
 import dlshade.org.apache.bookkeeper.meta.HierarchicalLedgerManagerFactory;
 import dlshade.org.apache.bookkeeper.meta.LayoutManager;
 import dlshade.org.apache.bookkeeper.meta.LedgerLayout;
 import dlshade.org.apache.bookkeeper.meta.LedgerManagerFactory;
-import dlshade.org.apache.bookkeeper.util.ReflectionUtils;
 import java.io.IOException;
 import org.junit.Test;
 import org.junit.runner.RunWith;