forked from apache/bookkeeper
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[BOOKIE-SHELL] Add cmd to change bookie-address into ledger metadata
### Motivation In a large bookie cluster environment, we frequently require a utility to change bookie-ip with a different bookie-ip in ledger's metadata in different scenarios such as: 1. Host Re-IP: requires updating ledger metadata and reuse the host without losing/copying data 2. Backup-restore usecase while doing cluster level data migration. Therefore, we frequently need a tool to update bookie-ip with a new bookie-ip in existing ledgers' ensemble metadata. ### Modification Add CLI command to update bookie-id in ledger metadata. Reviewers: Enrico Olivelli <[email protected]>, Sijie Guo <None>, Jia Zhai <[email protected]> This closes apache#2321 from rdhabalia/reip
- Loading branch information
Showing
4 changed files
with
313 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
186 changes: 186 additions & 0 deletions
186
...ain/java/org/apache/bookkeeper/tools/cli/commands/bookie/UpdateBookieInLedgerCommand.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,186 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.bookkeeper.tools.cli.commands.bookie; | ||
|
|
||
| import com.beust.jcommander.Parameter; | ||
| import com.google.common.util.concurrent.UncheckedExecutionException; | ||
| import java.io.IOException; | ||
| import java.util.concurrent.TimeUnit; | ||
| import lombok.Setter; | ||
| import lombok.experimental.Accessors; | ||
| import org.apache.bookkeeper.bookie.BookieShell; | ||
| import org.apache.bookkeeper.client.BKException; | ||
| import org.apache.bookkeeper.client.BookKeeper; | ||
| import org.apache.bookkeeper.client.BookKeeperAdmin; | ||
| import org.apache.bookkeeper.client.UpdateLedgerOp; | ||
| import org.apache.bookkeeper.conf.ClientConfiguration; | ||
| import org.apache.bookkeeper.conf.ServerConfiguration; | ||
| import org.apache.bookkeeper.net.BookieSocketAddress; | ||
| import org.apache.bookkeeper.tools.cli.helpers.BookieCommand; | ||
| import org.apache.bookkeeper.tools.framework.CliFlags; | ||
| import org.apache.bookkeeper.tools.framework.CliSpec; | ||
| import org.apache.bookkeeper.util.MathUtils; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| /** | ||
| * Command to update ledger command. | ||
| */ | ||
| public class UpdateBookieInLedgerCommand extends BookieCommand<UpdateBookieInLedgerCommand.UpdateBookieInLedgerFlags> { | ||
|
|
||
| static final Logger LOG = LoggerFactory.getLogger(UpdateBookieInLedgerCommand.class); | ||
|
|
||
| private static final String NAME = "update-bookie-ledger-cmd"; | ||
| private static final String DESC = "Update bookie in ledgers metadata (this may take a long time)."; | ||
|
|
||
| public UpdateBookieInLedgerCommand() { | ||
| this(new UpdateBookieInLedgerFlags()); | ||
| } | ||
|
|
||
| private UpdateBookieInLedgerCommand(UpdateBookieInLedgerFlags flags) { | ||
| super(CliSpec.<UpdateBookieInLedgerFlags>newBuilder() | ||
| .withName(NAME) | ||
| .withDescription(DESC) | ||
| .withFlags(flags) | ||
| .build()); | ||
| } | ||
|
|
||
| /** | ||
| * Flags for update bookie in ledger command. | ||
| */ | ||
| @Accessors(fluent = true) | ||
| @Setter | ||
| public static class UpdateBookieInLedgerFlags extends CliFlags { | ||
|
|
||
| @Parameter(names = { "-sb", "--srcBookie" }, | ||
| description = "Source bookie which needs to be replaced by destination bookie. <bk-address:port>") | ||
| private String srcBookie; | ||
|
|
||
| @Parameter(names = { "-db", "--destBookie" }, | ||
| description = "Destination bookie which replaces source bookie. <bk-address:port>") | ||
| private String destBookie; | ||
|
|
||
| @Parameter(names = { "-s", "--updatepersec" }, | ||
| description = "Number of ledgers updating per second (default: 5 per sec)") | ||
| private int updatePerSec = 5; | ||
|
|
||
| @Parameter(names = { "-r", | ||
| "--maxOutstandingReads" }, description = "Max outstanding reads (default: 5 * updatespersec)") | ||
| private int maxOutstandingReads = updatePerSec * 5; | ||
|
|
||
| @Parameter(names = {"-l", "--limit"}, | ||
| description = "Maximum number of ledgers of ledgers to update (default: no limit)") | ||
| private int limit = Integer.MIN_VALUE; | ||
|
|
||
| @Parameter(names = { "-v", "--verbose" }, description = "Print status of the ledger updation (default: false)") | ||
| private boolean verbose; | ||
|
|
||
| @Parameter(names = { "-p", "--printprogress" }, | ||
| description = "Print messages on every configured seconds if verbose turned on (default: 10 secs)") | ||
| private long printProgress = 10; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean apply(ServerConfiguration conf, UpdateBookieInLedgerFlags cmdFlags) { | ||
| try { | ||
| return updateLedger(conf, cmdFlags); | ||
| } catch (Exception e) { | ||
| throw new UncheckedExecutionException(e.getMessage(), e); | ||
| } | ||
| } | ||
|
|
||
| private boolean updateLedger(ServerConfiguration conf, UpdateBookieInLedgerFlags flags) | ||
| throws InterruptedException, BKException, IOException { | ||
|
|
||
| BookieSocketAddress srcBookieAddress; | ||
| BookieSocketAddress destBookieAddress; | ||
| try { | ||
| String[] bookieAddress = flags.srcBookie.split(":"); | ||
| srcBookieAddress = new BookieSocketAddress(bookieAddress[0], Integer.parseInt(bookieAddress[1])); | ||
| bookieAddress = flags.destBookie.split(":"); | ||
| destBookieAddress = new BookieSocketAddress(bookieAddress[0], Integer.parseInt(bookieAddress[1])); | ||
| } catch (Exception e) { | ||
| LOG.error("Bookie address must in <address>:<port> format"); | ||
| return false; | ||
| } | ||
|
|
||
| final int rate = flags.updatePerSec; | ||
| if (rate <= 0) { | ||
| LOG.error("Invalid updatespersec {}, should be > 0", rate); | ||
| return false; | ||
| } | ||
|
|
||
| final int maxOutstandingReads = flags.maxOutstandingReads; | ||
| if (maxOutstandingReads <= 0) { | ||
| LOG.error("Invalid maxOutstandingReads {}, should be > 0", maxOutstandingReads); | ||
| return false; | ||
| } | ||
|
|
||
| final int limit = flags.limit; | ||
| if (limit <= 0 && limit != Integer.MIN_VALUE) { | ||
| LOG.error("Invalid limit {}, should be > 0", limit); | ||
| return false; | ||
| } | ||
|
|
||
| final long printProgress; | ||
| if (flags.verbose) { | ||
| printProgress = 10; | ||
| } else { | ||
| printProgress = flags.printProgress; | ||
| } | ||
|
|
||
| final ClientConfiguration clientConfiguration = new ClientConfiguration(); | ||
| clientConfiguration.addConfiguration(conf); | ||
| final BookKeeper bk = new BookKeeper(clientConfiguration); | ||
| final BookKeeperAdmin admin = new BookKeeperAdmin(bk); | ||
| if (admin.getAvailableBookies().contains(srcBookieAddress) | ||
| || admin.getReadOnlyBookies().contains(srcBookieAddress)) { | ||
| bk.close(); | ||
| admin.close(); | ||
| LOG.error("Source bookie {} can't be active", srcBookieAddress); | ||
| return false; | ||
| } | ||
| final UpdateLedgerOp updateLedgerOp = new UpdateLedgerOp(bk, admin); | ||
|
|
||
| BookieShell.UpdateLedgerNotifier progressable = new BookieShell.UpdateLedgerNotifier() { | ||
| long lastReport = System.nanoTime(); | ||
|
|
||
| @Override | ||
| public void progress(long updated, long issued) { | ||
| if (printProgress <= 0) { | ||
| return; // disabled | ||
| } | ||
| if (TimeUnit.MILLISECONDS.toSeconds(MathUtils.elapsedMSec(lastReport)) >= printProgress) { | ||
| LOG.info("Number of ledgers issued={}, updated={}", issued, updated); | ||
| lastReport = MathUtils.nowInNano(); | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| try { | ||
| updateLedgerOp.updateBookieIdInLedgers(srcBookieAddress, destBookieAddress, rate, maxOutstandingReads, | ||
| limit, progressable); | ||
| } catch (IOException e) { | ||
| LOG.error("Failed to update ledger metadata", e); | ||
| return false; | ||
| } | ||
|
|
||
| return true; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters